- App Store
Bug Tracker Incident #9302
Tested in xtuple version 4.0.0 Beta3: Closing the issue based on the latest comment
Empty address are allowed - The address is not a key. There is an address number (not shown on the GUI) that is the key.
Tested in xTuple version 4.0.0 Beta3: Observed that issue still reproducible in following scenarios.
Empty address are allowed
response to code review comments: First off, thanks for slogging through all of that.
> rev 13992 in uniqueCodes.sql, line ALTER TABLE "char" changed to ALTER TABLE char?<--same thing in fixNonUniqueCodes.sql
CHAR is a keyword in SQL and so has to be quoted when we refer to the table with that name. "char" was a poor choice for a table name but it's too late to change that(?).
> Precheck file needs some sort of extension, .sql?
Nope - the Precheck file is there as a reminder to the person who builds the upgrade package to include those statements in the package.xml file, with appropriate messages to give the user guidance on how to fix the problem before the upgrade can be completed. This file is not intended to be run directly as part of the upgrade.
> rev 13993 printQuote.cpp
This particular change was backed out in rev 13994. Even so, this is legal MetaSQL syntax and the query string defined in the .cpp file is passed to the MetaSQL parser before it's executed.
> rev 13999 transferOrder.cpp couple references to ;//nothing to do, remove the queries?
We can't remove the queries because they do actual work (addToPackingListBatch and releaseToNumber). There used to be error-handling code in the blocks after QSqlQuery::first() but that's no longer necessary. The empty statements are there as place-holders until we decide how to deal with them as part of fixing 8330 and the comments are there to ensure maintainers notice them.
> rev 8795 Precheck file needs an extension, .sql?
> $$ LANGUAGE PLPGSQL; possibly needs to be single quoted in file fixNonUniqueCodes.sql
Turns out that isn't necessary. From http://www.postgresql.org/docs/8.4/interactive/sql-createfunction.html :
rev 13992 in uniqueCodes.sql, line ALTER TABLE "char" changed to ALTER TABLE char?<--same thing in fixNonUniqueCodes.sql
rev 13993 printQuote.cpp
rev 13999 transferOrder.cpp couple references to ;//nothing to do, remove the queries?
rev 8795 Precheck file needs an extension, .sql?
Commits not automatically added as comments on this issue:
Most of the changes for this issue prevent database inserts and updates that would create NULL, empty, or duplicate numbers/codes/names/etc. These were usually prevented by desktop client or script code but could still be created with data import via CSV or XML or SQL or other clients.
These changes do not address the complaint about empty comments. Internal discussion revealed that there are use cases for these. These changes also do not address potential concerns about numbers/codes/names/etc. consisting entirely of whitespace characters.
User is allowed to save duplicate Sales Rep Groups
Quotes can be created with blank quote numbers (16747 reported in 3.8.0RC2)
Duplicate Tax Registrations with exactly same details can be created
Here are some examples found:
It is possible to duplicate class codes
Disallow records with duplicate or blank human readable key values. Let's roll this into a single effort to stem the tidal wave of reports on this subject for every manifestation. We've had similar issues, such as problems with displays that require us to scour the app.
Any examples found should be added to the additional information section of this issue.
|Project||XTUPLEAPPS||Ported From Mantis||x|
SubscribersYou do not have permission to view subscribers.
|12/16/10 09:14||acdrupal||New||Incident Added|
|12/14/11 07:53||gmoskowitz||Description Updated: "Disallow records wit..." -> "Disallow records wit..."|
|12/14/11 07:53||gmoskowitz||Priority||Priority Changed: Normal -> High|
|12/14/11 08:03||gmoskowitz||Found In: -> 3.3.0Beta3|
|08/13/12 14:39||gmoskowitz||Status||Status Changed: Confirmed -> Assigned|
|08/13/12 14:39||gmoskowitz||Assigned||Assigned to: "" -> "gmoskowitz"|
|08/27/12 16:08||gmoskowitz||Characteristic CodeReview Added: "Needed"|
|08/27/12 16:08||gmoskowitz||Status||Status Changed: Assigned -> Resolved|
|08/27/12 16:08||gmoskowitz||Resolution||Resolution Changed: Open -> Fixed|
|08/27/12 16:08||gmoskowitz||Fixed In: -> 4.0.0|
|08/27/12 16:09||gmoskowitz||Characteristic BugHunt2012 Added: "yes"|
|08/31/12 13:25||gmoskowitz||Characteristic CodeReview Changed: "Needed" -> "In Progress"|
|08/31/12 17:22||gmoskowitz||Characteristic CodeReview Changed: "In Progress" -> "Completed"|
|11/07/12 08:33||shyamsunder||Description Updated: "Disallow records wit..." -> "Disallow records wit..."|
|11/07/12 08:33||shyamsunder||Status||Status Changed: Resolved -> Assigned|
|11/07/12 08:33||shyamsunder||Characteristic Regression Added: "No"|
|11/07/12 10:12||jrogelstad||Characteristic CodeReview Changed: "Completed" -> "Needed"|
|11/07/12 10:12||jrogelstad||Status||Status Changed: Assigned -> Resolved|
|11/07/12 10:12||jrogelstad||Characteristic CodeReview Changed: "Needed" -> "Completed"|
|11/08/12 01:32||shyamsunder||Status||Status Changed: Resolved -> Closed|