Bug Tracker Incident #8430

 


Summary
Project
INCDT - xTuple ERP
Incident Category
Bugs
Incident Number
8430
Visibility
public


Product Version
3.2.1
Fixed In Version
3.3.0Alpha


Summary
Missing return from Screen::submit()


Description

bool Screen::submit()

Compiler warning:
/postbooks/xtuple/tags/R3_2_1/widgets/screen.cpp:146:
warning: control reaches end of non-void function

No return from method, so I added one.

It should definitely return the boolean rather than be declared void : calling code is expecting the boolean value
[snip]
void Screen::save()
{
if (submit())
[/snip]

Patch attached.


Details
Reporter
petebisson
CRM Account
xTincident Default Account
Status
Closed
Assigned
cryan


Priority
Normal
Severity
Patch
Updated
09-06-12 15:39
Resolution
Fixed



Comments

DateUsernameComment
03/04/11 08:25mfgadmin

bool Screen::submit()

Compiler warning:
/postbooks/xtuple/tags/R3_2_1/widgets/screen.cpp:146:
warning: control reaches end of non-void function

No return from method, so I added one.

It should definitely return the boolean rather than be declared void : calling code is expecting the boolean value
[snip]
void Screen::save()
{
if (submit())
[/snip]

Patch attached.

08/14/09 14:19gmoskowitz

verified by code inspection and recompiling screen.cpp

02/09/09 16:06svn

Revision: 5217
http://postbooks.svn.sourceforge.net/postbooks/?rev=5217&view=rev
Author: cryan
Date: 2009-02-09 21:06:47 +0000 (Mon, 09 Feb 2009)

Log Message:
-----------
Incoporated patch submitted by user petebisson to add missing return. Issue #8430.

Modified Paths:
--------------
xtuple/trunk/widgets/screen.cpp



Characteristics

Operating System
 
Doc Flag
False
Copyright Assigned
Yes
HaxTuple
No

Files

Filename
screen.submit.patch


Related Documents

TypeNumberDescriptionRelationshipRemove
Incident4088Item source Allows Duplicate Entry for Price BreakRelated tox
ProjectXTUPLEAPPSPorted From Mantisx


Subscribers

You do not have permission to view subscribers.


Incident History

DateUsernameFieldChange
12/16/10 09:13acdrupalNewIncident Added